Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binaries by name #44

Merged
merged 4 commits into from
Feb 14, 2021
Merged

Update binaries by name #44

merged 4 commits into from
Feb 14, 2021

Conversation

ernesto27
Copy link
Contributor

Hi, marcos.
This is a pull requestes related to the issue #43

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Get latest changes
cmd/update.go Outdated Show resolved Hide resolved
cmd/update.go Outdated Show resolved Hide resolved
@ernesto27
Copy link
Contributor Author

I added a basic check to prevent call LookPath if command is called in this way $(which command), and change the function name.

I see that other option to solve this issue would be to use the file HOME/.bin/config.json to check
the path and prevent to call function LookPath, it would be a better option, WDYT?

@marcosnils marcosnils merged commit 6f15a2f into marcosnils:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants