Adds a "provider" flag to update a install commands #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flags allows installing binaries from providers that doesn't follow our initial URL resolution scheme.
sirlatrom
reviewed
Mar 15, 2021
| SilenceUsage: true, | ||
| SilenceErrors: true, | ||
| Args: cobra.MaximumNArgs(2), | ||
| Args: cobra.MinimumNArgs(1), |
There was a problem hiding this comment.
I don't believe this change is strictly necessary, as the number of Args is not the same as the number of flags. However, if it is needed to make something else work, I don't see a problem with keeping it.
There was a problem hiding this comment.
Oh, this change is unrelated to this PR. I just realized that we didn't configure that correctly and I'm fixing that here since bin install always requires a minimum of a 1 argument to work :D
sirlatrom
reviewed
Mar 15, 2021
Co-authored-by: Sune Keller <sune.keller+github@gmail.com>
|
Thx for reviewing @sirlatrom . I believe it's ready for a second review and merge if approved. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flags allows installing binaries from providers that doesn't follow
our initial URL resolution scheme.