Modified config to utilize the os.UserHomeDir() vs user.Current().HomeDir #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify config.go to use os.UserHomeDir() function which supports env variables vs mandating CurrentUser
Modifed to use the os.UserHomeDir() function to take into consideration user's ENV variables, and XDG Base Directory Specification
marcosnils
approved these changes
Mar 16, 2021
|
Preciate the contribution Zac, will craft a release with some updates later today 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from user.Current().HomeDir to us the go function: os.UserHomeDir()
This change allows users to modify their home directory via environment variables (plan9 on Unix, and %USERPROFILE% on windows), vs mandating the OS-specified "current" user setting be used. This allows a more "portable" use of your application.
For more info on this function see:
https://golang.org/src/os/file.go?s=14576:14610#L483