Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implemented nested logicalType check #734

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

bengels97
Copy link
Contributor

@bengels97 bengels97 commented Aug 26, 2024

Original issue described in: #726

Included a logicalType key check in BaseGenerator.parse_logical_type that does not break any of the existing model generations. But does enable the generation of a model for a schema with logicalType and type not defined under a type key (as described in the issue).

Note that my linter has updated some of the indentations in the code.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (a2239b2) to head (00b2564).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files          34       34           
  Lines        1947     1947           
=======================================
  Hits         1937     1937           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosschroh marcosschroh merged commit c4c3003 into marcosschroh:master Aug 26, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants