ProxyOptions exposes ProxySelector, remove proxy settings from OtlpGr… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pc{Signal}ExporterBuilder, remove proxy autoconfigure settings, add proxy e2e test with mock server
trask
reviewed
Feb 29, 2024
| @@ -120,8 +118,7 @@ private static HttpClient configureClient( | |||
| builder.sslContext(sslContext); | |||
| } | |||
| if (proxyOptions != null) { | |||
| builder.proxy( | |||
| ProxySelector.of(new InetSocketAddress(proxyOptions.getHost(), proxyOptions.getPort()))); | |||
| builder.proxy(proxyOptions.getProxySelector()); | |||
There was a problem hiding this comment.
it's nice to see how we can just pass the ProxySelector down, helps confirm this approach 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my proposal here.
Notably, I removed the env var options for
otel.exporter.otlp.*.proxy.host.*. The env variables we support are bounded by the spec (the relevant file for these options is here), so we'd need to get the spec updated before including these.