Refactored variable name to selected questions

marcusgreen · Sep 30, 2024 · 611c46b · 611c46b
1 parent 970851d
commit 611c46b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/classes/helper.php b/classes/helper.php
@@ -34,7 +34,7 @@ class helper {
     public static function bulk_tag_questions($fromform) {
         global $DB;
         $tags = $fromform->formtags;
-        if ($questionids = explode(',', $fromform->tagsquestionsselected)) {
+        if ($questionids = explode(',', $fromform->selectedquestions)) {
             [$usql, $params] = $DB->get_in_or_equal($questionids);
             $sql = "SELECT q.*, c.contextid
                       FROM {question} q

diff --git a/classes/output/form/bulk_tags_form.php b/classes/output/form/bulk_tags_form.php
@@ -39,8 +39,8 @@ protected function definition() {
         $mform = $this->_form;
 
         // Add hidden form fields.
-        $mform->addElement('hidden', 'tagsquestionsselected');
-        $mform->setType('tagsquestionsselected', PARAM_TEXT);
+        $mform->addElement('hidden', 'selectedquestions');
+        $mform->setType('selectedquestions', PARAM_TEXT);
         $mform->addElement('hidden', 'returnurl');
         $mform->setType('returnurl', PARAM_URL);
         $mform->addElement('hidden', 'cmid');
@@ -76,7 +76,7 @@ protected function definition() {
     public function set_data($data) {
         $mform = $this->_form;
         $data = (object) $data;
-        $mform->getElement('tagsquestionsselected')->setValue($data->tagsquestionsselected);
+        $mform->getElement('selectedquestions')->setValue($data->selectedquestions);
         $mform->getElement('returnurl')->setValue($data->returnurl);
         $mform->getElement('cmid')->setValue($data->cmid);
         $mform->getElement('courseid')->setValue($data->courseid);

diff --git a/tag.php b/tag.php
@@ -79,7 +79,7 @@
     }
      // Create the urls.
      $bulktagsparams = [
-         'tagsquestionsselected' => $questionlist,
+         'selectedquestions' => $questionlist,
          'confirm' => md5($questionlist),
          'sesskey' => sesskey(),
          'returnurl' => $returnurl,

diff --git a/tests/helper_test.php b/tests/helper_test.php
@@ -77,7 +77,7 @@ public function test_bulk_tag_questions(): void {
 
         $fromform = (object) [
             'tags' => ['tag1', 'tag2'],
-            'tagsquestionsselected' => implode(",", [$this->question1->id, $this->question2->id]),
+            'selectedquestions' => implode(",", [$this->question1->id, $this->question2->id]),
             'formtags' => ['foo', 'bar'],
             'replacetags' => 0,
         ];