Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix question compatibility with Dark theme #100

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

bi1101
Copy link
Contributor

@bi1101 bi1101 commented Dec 13, 2022

No description provided.

@marcusgreen
Copy link
Owner

marcusgreen commented Dec 13, 2022

Is there a theme or setting I can test this against? Ahh is it this
https://tracker.moodle.org/browse/MOBILE-3144

@bi1101
Copy link
Contributor Author

bi1101 commented Dec 14, 2022

There is a Dark theme in the Moodle App that you can try.
Yes I believe that is the theme that I was talking about

@marcusgreen
Copy link
Owner

Thank you, I will set it up and have a look. Thank you for the feedback.

Repository owner deleted a comment from catalyst-eu Dec 14, 2022
@marcusgreen
Copy link
Owner

Yes, the text is almost unreadable in dark mode. I will test out your code.

@marcusgreen marcusgreen merged commit a1ffde8 into marcusgreen:master Dec 24, 2022
@marcusgreen
Copy link
Owner

I like to add a credit to the changelog file when I release to the moodle.org plugins database
https://github.com/marcusgreen/moodle-qtype_gapfill/blob/master/changelog.md
What name should put against this change or should I use bi1101?

@bi1101
Copy link
Contributor Author

bi1101 commented Dec 24, 2022

Oh yes! Thank you that's very nice of you, bi1101 is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants