Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Bring key mappings up to date with tcell #48

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

TripleDogDare
Copy link
Contributor

This adds missing string mappings for the named key codes (Should address parts of #41). (Except for KeyCtrlLeftSq which is Escape). Unfortunately I don't see anything for additional media keys and I'm pretty sure those would have to be surfaced by tcell as currently implemented.

Signed-off-by: Calvin Behling <calvin.behling@gmail.com>
@marcusolsson
Copy link
Owner

I tried running xdotool key XF86AudioPlay and like you say, it doesn't seem like media keys are supported by tcell. The idea from the start has been to rely on a third-party library for the actual communication with the terminal. In fact, originally tui-go was termbox-go for this, but I later felt tcell supported more of the things I had imagined for tui.

If media keys turns out to be a highly requested feature, then I think that it should preferably be implemented in tcell first

Either way, thanks for your contribution! Much appreciated!

@marcusolsson marcusolsson merged commit 73b6923 into marcusolsson:master Jul 26, 2017
@marcusolsson marcusolsson mentioned this pull request Sep 23, 2017
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants