This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Clear Keybindings functionality #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for wanting to contribute! Just spitballing here but to me the word "Reset" implies returning to a semantically default state. This is sort of the case here but my gut feeling would tell me that "Reset" could be something more than just removing all keybindings. For example, if there were standard keybindings like Esc for quitting, that would persist even after removing them, then Reset could be appropriate. How about "ClearKeybindings" maybe? |
|
Hmm, I take your point. For example for my project I may use ResetKeybindings() to first clear all keybindings and then set the exit mechanism. |
ui_tcell.go
Outdated
| @@ -64,6 +64,12 @@ func (ui *tcellUI) SetKeybinding(seq string, fn func()) { | |||
| }) | |||
| } | |||
|
|
|||
| // ClearKeygindings reinitializes the keybindings so as to revert to the | |||
tokamak-git
changed the title
|
Thank you! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
The pr adds the ability to reset keybindings so as to start afresh. this is done by simply
ui.Keybindings = make([]*keybindings, 0)Your feedback is more than welcome