added plot_map

[marcusvolz]

No description provided.

[hugovk]

Nice addition! Some comments and suggestions :)

[hugovk]

Nit: remove full stop to match the facets alt text.

Suggested change

	
	

[hugovk]

Include -- prefixes otherwise it complains about:

usage: strava_py [-h] [-o OUTPUT_FILE] path lon_min lon_max lat_min lat_max alpha linewidth
strava_py: error: the following arguments are required: lon_min, lon_max, lat_min, lat_max, alpha, linewidth

Suggested change

	parser.add_argument("lon_min", default=None, help="Minimum longitude for plot_map (values less than this are removed from the data)")
	parser.add_argument("lon_max", default=None, help="Maximum longitude for plot_map (values greater than this are removed from the data)")
	parser.add_argument("lat_min", default=None, help="Minimum latitude for plot_map (values less than this are removed from the data)")
	parser.add_argument("lat_max", default=None, help="Maximum latitude for plot_map (values greater than this are removed from the data)")
	parser.add_argument("alpha", default=0.4, help="Line transparency. 0 = Fully transparent, 1 = No transparency")
	parser.add_argument("linewidth", default=0.4, help="Line width")
	parser.add_argument("--lon_min", default=None, help="Minimum longitude for plot_map (values less than this are removed from the data)")
	parser.add_argument("--lon_max", default=None, help="Maximum longitude for plot_map (values greater than this are removed from the data)")
	parser.add_argument("--lat_min", default=None, help="Minimum latitude for plot_map (values less than this are removed from the data)")
	parser.add_argument("--lat_max", default=None, help="Maximum latitude for plot_map (values greater than this are removed from the data)")
	parser.add_argument("--alpha", default=0.4, help="Line transparency. 0 = Fully transparent, 1 = No transparency")
	parser.add_argument("--linewidth", default=0.4, help="Line width")

[hugovk]

Nit: alphabetical order helps as number of imports grows:

Suggested change

	from strava_py.plot_map import plot_map
	from strava_py.plot_facets import plot_facets
	from strava_py.process_data import process_data
	from strava_py.plot_facets import plot_facets
	from strava_py.plot_map import plot_map
	from strava_py.process_data import process_data

[hugovk]

Turns out we need to explicitly create a new figure here and same place in plot_facets:

Suggested change

	# Create a new figure
	plt.figure()

Otherwise the map plot is like this -- a facet plot with the map in the last slot:

[hugovk]

Call plot_map and also pass the CLI args:

Suggested change

	plot_facets(df, output_file=args.output_file)
	print(f"Saved to {args.output_file}")
	plot_map(
	df,
	lon_min=args.lon_min,
	lon_max=args.lon_max,
	lat_min=args.lat_min,
	lat_max=args.lat_max,
	alpha=args.alpha,
	linewidth=args.linewidth,
	output_file=args.output_file,
	)
	print(f"Saved to {args.output_file}")

[hugovk]

We're also re-using args.output_file and therefore writing over the facets image.

Some options:

• Remove the argument entirely
• Add a second one for the map plot
• Change the argument to be a prefix instead (e.g. strava), and we append -facets.png and -map.png

I think the third, as there may be more visualisations added soon, and it will be useful to be able to have different names for different runs (for example, I might generate output for each year of activities, or summer vs. winter).

[hugovk]

Defaults are 0.3 here and 0.4 for the CLI. Should they be the same?