Require calmap>=0.0.11 to support Pandas 2 #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #32.
https://pypi.org/project/calmap/0.0.11/ has been released and now supports Pandas 2, so we can remove the
pandas<2
limit.This also revealed a problem with Pandas 2 in stravavis:
It's this line:
Printing those with Pandas 1.5.3:
Gives:
So: datetime64[ns] + object = datetime64[ns], that's fine.
But with Pandas 2.0.3:
datetime64[ns] + object = object
Instead, let's make sure the end time is a datetime:
This works with both Pandas < 2 and >=2.