Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix/auto grow textinput #10

Closed
wants to merge 5 commits into from
Closed

Conversation

hannojg
Copy link
Member

@hannojg hannojg commented Jun 9, 2023

Based on/merge first:

Main changes

  • Remove manually auto grow behaviour on mobile, as on mobile autoGrow is supported
  • Remove controlled selection prop as its unnecessary, causing unnecessary re-renders, and UI glitches
  • ...

@parasharrajat
Copy link

Happy to review this.

@hannojg
Copy link
Member Author

hannojg commented Jun 12, 2023

@parasharrajat Your the best thx, will let you know once its done, and will mention you on the PR that we will open against Expensify's app repository!

…ithub.com:margelo/expensify-app-fork into fix/auto-grow-textinput
@parasharrajat
Copy link

@hannojg Do you think we can work on this getting merged now?

@hannojg
Copy link
Member Author

hannojg commented Jul 14, 2023

Hey @parasharrajat , the main issue with this one is that there is a native react native bug causing part of this behaviour which we very likely have to fix first (or find another solution).
I think I'll be available for looking into it either end of next week or the week after, so its still a bit on hold ...

@parasharrajat
Copy link

No worries. Thanks for the update.

perunt pushed a commit that referenced this pull request Oct 4, 2023
kirillzyusko pushed a commit that referenced this pull request Feb 5, 2024
…-settings

Improve workspace settings on Main Pane
perunt pushed a commit that referenced this pull request Feb 13, 2024
* fix: ubo list hover, incorp state hover

* feat: improved return type for getFieldRequiredErrors
perunt pushed a commit that referenced this pull request Feb 14, 2024
chrispader pushed a commit that referenced this pull request Apr 17, 2024
…tion-report-view

Revert "Add One Transaction Report View"
@hannojg
Copy link
Member Author

hannojg commented Oct 4, 2024

@hannojg hannojg closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants