Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useWorkletCallback returned unstable ref #226

Merged
merged 1 commit into from
Jul 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions package/src/hooks/useWorkletCallback.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,27 @@
import { useWorklet } from 'react-native-worklets-core'
import { getWorkletDependencies } from 'react-native-worklets-core'
import { useFilamentContext } from './useFilamentContext'
import { wrapWithErrorHandler } from '../ErrorUtils'
import { useMemo } from 'react'

/**
* Creates a callback that can be executed in he separate worklet thread of the engine.
*/
export function useWorkletCallback<T extends (...args: any[]) => any>(callback: T): (...args: Parameters<T>) => Promise<ReturnType<T>> {
const { workletContext } = useFilamentContext()

return useWorklet(workletContext, wrapWithErrorHandler(callback))
// Note: from react-native-worklets-core/useWorklet
// As we want to wrap using `wrapWithErrorHandler` the dependencies must be captured from the
// callback, not from the wrapper.

// As a dependency for this use-memo we use all of the values captured inside the worklet,
// as well as the unique context name.
const dependencies = [...getWorkletDependencies(callback)]

return useMemo(
() => {
return workletContext.createRunAsync(wrapWithErrorHandler(callback))
},
// eslint-disable-next-line react-hooks/exhaustive-deps
dependencies
)
}