-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oneDNN + MKL #967
Open
graemenail
wants to merge
28
commits into
marian-nmt:master
Choose a base branch
from
graemenail:mkl-onednn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
oneDNN + MKL #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile time preference: 1. MKL 2. oneDNN 3. Other BLAS
The BLAS_FOUND ifdef guards are removed as sgemm already has an abort.
This reverts commit 735ef42.
This change was requested to avoid silently falling back to slower BLAS implementations.
graemenail
force-pushed
the
mkl-onednn
branch
from
November 2, 2022 13:22
d691b98
to
3e1a550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Description
Adds oneDNN. This PR should enable a completely open-source compilations of Marian.
In contrast to #937, this PR also allows MKL-based builds. When compiled with
-DUSE_DNNL=ON
, oneDNN is used for sgemm, even if-DUSE_MKL=ON
is requested.This PR also includes a caching of boost, and a cleaning of the debug build directory. These can be broken off into a separate PR if necessary. During testing, windows builds would fail from running out of space building both debug and release. Since disabling oneDNN JIT profiling the build sizes are smaller.
Related: marian-nmt/marian-regression-tests#86
Closes: #706
Supersedes: #937
List of changes:
BLAS_FOUND
is sufficient here and theMKL_FOUND
condition could be omitted by a user expecting a performance degradation.Added dependencies: Intel oneDNN
How to test
Ran the 1 million sentence testset of WNGT21 through the MKL and oneDNN versions.
The static binaries are now larger.
Regression test results
Checklist