Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @marimo-team/islands esm package #2008

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: @marimo-team/islands esm package #2008

wants to merge 2 commits into from

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Aug 12, 2024

POC / untested

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:20am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:20am

@mscolnick
Copy link
Contributor Author

This complicates things a bit since previously we were bundling react, but when exporting as a React component, the user likely brings their own react, so we would need to now externalize.

I may table this for a bit, but instead add the <marimo-app> tag that is in this PR, but still not export React components just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant