Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encoding table elements when passed through RPC calls #2358

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Sep 19, 2024

Fixes #2357

asdict does not encode our UI elements properly and should be used sparingly

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 1:25am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 1:25am

akshayka
akshayka previously approved these changes Sep 19, 2024
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting a table with mixed values and ui elements leads to ui elements not rendered
2 participants