fix: handle shadowed variables in mo.cache, update tutorials #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Is this on the cache hit? |
akshayka
commented
Oct 2, 2024
marimo/_save/save.py
Outdated
Comment on lines
117
to
119
| # In case scope shadoes variables | ||
| for arg in self._args: | ||
| self.scope.pop(arg, None) |
There was a problem hiding this comment.
ah this is what I was looking for
… error is probably best (at least a warning maybe?)
dmadisetti
reviewed
Oct 3, 2024
| import functools | ||
|
|
||
|
|
||
| @functools.cache |
There was a problem hiding this comment.
You can check with _plots.cache_info().hits, and as was, there would never be a cache hit with functools, since the function would get redefined and clear the cache
I did find that for, mo.cache, private functions did not have a persistent cache- but solved that
dmadisetti
reviewed
Oct 3, 2024
akshayka
changed the title
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.8.23-dev26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates tutorials to use
mo.cache, and fixesmo.cacheto handle shadowed variables.