First stab at new devcontainer #233
Conversation
| [group('test')] | ||
| test: kustomization-tests | ||
|
|
||
| regen-yarn-sdks: |
There was a problem hiding this comment.
Ah...this is how it is generated. It might be nice to add a comment to the files after generated in this to say it's generated and how to rerun.
Do we need to add CI to make sure we don't need to apply changed to this with updates?
There was a problem hiding this comment.
I'm wary of touching the files - it's probably safer to leave this as a black box, but I don't know when it should be updated
There was a problem hiding this comment.
I figure we can make a job that runs this, and if there's any code changes, it'll fail and we know we need to handle that. Alternatively...we could just run this as a setup to our devcontainer and then add it to the gitignore file so we don't even version it.
Neither is blocking for this PR.
justfile
Outdated
| hado-lint: | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
| find . -name "Dockerfile*" -print | xargs -r -n1 hadolint |
There was a problem hiding this comment.
Similarly, better output example with a loop: https://github.com/sdwilsh/ansible-playbooks/blob/main/justfile#L27
| kustomization-tests: | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
| find kustomization/tests -mindepth 1 -maxdepth 1 -type d -print | \ |
There was a problem hiding this comment.
Probably a good idea to do a loop here as well.
| "version": "2.12.0" | ||
| }, | ||
| "ghcr.io/devcontainers/features/node:1": { | ||
| // TODO: figure out how to version node |
There was a problem hiding this comment.
From the docs, it looks like we can just supply version here: https://github.com/devcontainers/features/tree/main/src/node
I think we want v23.5.0. I don't know if you care to also version npm, etc
There was a problem hiding this comment.
For this and the other one, I wasn't sure what the renovate line should look like. Separately, the risk of picking a specific version here is that it gets pulled from upstream quickly and then your build breaks. Mostly I noticed this with the gh cli
There was a problem hiding this comment.
We can always have renovate wait a few days to help I guess?
| }, | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": { | ||
| // TODO: figure out docker versioning story here |
There was a problem hiding this comment.
docs say it's just version: https://github.com/devcontainers/features/tree/main/src/docker-in-docker
I think we want v27.4.1
No description provided.