Write failing test and fix accessing a property of an object with nul…

…l prototype.
mariocasciaro · Jun 30, 2016 · 1d75e39 · 1d75e39
1 parent 60e05c9
commit 1d75e39
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -79,7 +79,7 @@
     };
 
     function getShallowProperty(obj, prop) {
-      if(options.includeInheritedProps || (typeof prop === 'number' && Array.isArray(obj)) || obj.hasOwnProperty(prop)) {
+      if (options.includeInheritedProps || (typeof prop === 'number' && Array.isArray(obj)) || _hasOwnProperty.call(obj, prop)) {
         return obj[prop];
       }
     }

diff --git a/test.js b/test.js
@@ -102,6 +102,17 @@ describe('get', function() {
     expect(objectPath.get(undefined, 'test', 'a')).to.be.deep.equal('a');
   });
 
+  it(
+    'should not fail on an object with a null prototype',
+    function assertSuccessForObjWithNullProto(){
+      // TODO: verify this works on node 0.10
+      var foo = 'FOO';
+      var objWithNullProto = Object.create(null);
+      objWithNullProto.foo = foo;
+      expect(objectPath.get(objWithNullProto, 'foo')).to.equal(foo);
+    }
+  );
+
   it('should skip non own properties', function() {
     var Base = function(enabled){ };
     Base.prototype = {
@@ -772,7 +783,7 @@ describe('bind object', function () {
   });
 });
 
-describe('Don\' access not own properties [default]', function () {
+describe('Don\'t access not own properties [default]', function () {
   it('should not get a not own property', function() {
     var Obj = function() {};
     Obj.prototype.notOwn = {a: 'a'};