Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multistage labels in FileBuilder #178

Closed
macsux opened this issue Mar 16, 2021 · 6 comments · Fixed by #180
Closed

Add support for multistage labels in FileBuilder #178

macsux opened this issue Mar 16, 2021 · 6 comments · Fixed by #180
Assignees
@mariotoffia
Labels
enhancement waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further.
Milestone
3.0.0

Comments

@macsux
Copy link

macsux commented Mar 16, 2021

Allow assigning labels in FileBuilder for intermediate container images such as

FROM someimage AS myImage

and allow referring to in COPY directive to generate Dockerfile equivalent of

COPY --from=myImage ["/app", "/app"]
@mariotoffia mariotoffia mentioned this issue Mar 17, 2021
Merged
@mariotoffia mariotoffia self-assigned this Mar 17, 2021
@mariotoffia mariotoffia added enhancement under-development Denotes that a issue is under development but not yet released. labels Mar 17, 2021
@mariotoffia mariotoffia added this to the 3.0.0 milestone Mar 17, 2021
mariotoffia added a commit that referenced this issue Mar 17, 2021
@mariotoffia
Copy and from enhanced as per Issue #178
8460e6f
mariotoffia added a commit that referenced this issue Mar 17, 2021
@mariotoffia
New commands in FileBuilder as per Issue #177 #178
08fe0ce 
ENV, ARG, ENTRYPOINT, LABEL, USER, VOLUME.
Also support for the new parameters on FROM, COPY.
@mariotoffia
Copy link
Owner

I've compiled a pre-release - please have a go https://www.nuget.org/packages/Ductus.FluentDocker/2.8.8-beta.14

@mariotoffia mariotoffia added waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further. and removed under-development Denotes that a issue is under development but not yet released. labels Mar 17, 2021
@mariotoffia
Copy link
Owner

@macsux Please report back if it works or if you have any issues.

@mariotoffia mariotoffia reopened this Mar 17, 2021
@macsux
Copy link
Author

macsux commented Mar 22, 2021 •
edited
Loading

ImageBuilder should have an overload for its From with asLabel into FileBuilder.

@mariotoffia
Copy link
Owner

Hmmm I'm unsure what you want here. What would this duplicate asLabel provide with that From do not provide?

@macsux
Copy link
Author

macsux commented Mar 22, 2021

Because you can start From on the ImageBuilder, the overload that includes "asLabel" parameter should be available on the ImageBuilder as well.

@mariotoffia
Copy link
Owner

Got'ya

mariotoffia added a commit that referenced this issue Mar 22, 2021
@mariotoffia
ImageBuilder.From(imageAsTag,asName).
e91f1cb 
Closes issue #178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariotoffia mariotoffia

Labels
enhancement waiting-for-feedback Waiting for someone to give feedback until this issue can be brought further.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Add features to Docker FileBuilder mariotoffia/FluentDocker
2 participants
@macsux @mariotoffia