Skip to content

Commit

Permalink
[stable/memcached] Add updateStrategy configuration option (helm#16358)
Browse files Browse the repository at this point in the history
* [stable/memcached] Add updateStrategy configuration option

Signed-off-by: Remington Reackhof <rreackhof@rmn.com>

* [stable/memcached] Set specific keys for updateStrategy to follow convention

Signed-off-by: Remington Reackhof <rreackhof@rmn.com>

* [stable/memcached] Fix README to reflect updateStrategy.type value requirement

Signed-off-by: Remington Reackhof <rreackhof@rmn.com>
Signed-off-by: Marius Voila <myself@mariusv.com>
  • Loading branch information
RemingtonReackhof authored and mariusv committed Sep 16, 2019
1 parent cdb3ade commit dc013bd
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stable/memcached/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: memcached
version: 2.9.0
version: 2.10.0
appVersion: 1.5.12
description: Free & open source, high-performance, distributed memory object caching
system.
Expand Down
1 change: 1 addition & 0 deletions stable/memcached/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ The following table lists the configurable parameters of the Memcached chart and
| `securityContext.enabled` | Enable security context | `true` |
| `securityContext.fsGroup` | Group ID for the container | `1001` |
| `securityContext.runAsUser`| User ID for the container | `1001` |
| `updateStrategy.type` | Update strategy for the StatefulSet/Deployment | `RollingUpdate` |

The above parameters map to `memcached` params. For more information please refer to the [Memcached documentation](https://github.com/memcached/memcached/wiki/ConfiguringServer).

Expand Down
5 changes: 5 additions & 0 deletions stable/memcached/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,8 @@ spec:
affinity:
{{ toYaml . | trim | indent 8}}
{{- end }}
updateStrategy:
type: {{ .Values.updateStrategy.type }}
{{- if (eq "Recreate" .Values.updateStrategy.type) }}
rollingUpdate: null
{{- end }}
6 changes: 6 additions & 0 deletions stable/memcached/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ serviceAnnotations: {}
## StatefulSet or Deployment
kind: StatefulSet

## Update Strategy for the StatefulSet or Deployment
## ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#update-strategies
## ref: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#updating-a-deployment
updateStrategy:
type: RollingUpdate

## Configure resource requests and limits
## ref: http://kubernetes.io/docs/user-guide/compute-resources/
##
Expand Down

0 comments on commit dc013bd

Please sign in to comment.