Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets inconsistencies. #249

Closed
anonymous1184 opened this issue Oct 6, 2022 · 1 comment
Closed

Snippets inconsistencies. #249

anonymous1184 opened this issue Oct 6, 2022 · 1 comment
Assignees
Labels
bug something isn't working template template for a new AHK script

Comments

@anonymous1184
Copy link

anonymous1184 commented Oct 6, 2022

The v3.0.0 includes #202, and the logic behind the changes is that v2 compatibility is improved.

#Warn is missing; it should (must?) be enabled. I don't even know why AHK has an option to disable it.

The #SingleInstance directive has the same default value in both versions. Why use it on the extension template? The AHK default template doesn't use it.

Wouldn't be more appropriate not to have a template? It is cumbersome to delete it every time a new file is created (to the point I override the snippet with a blank one).

Also, more importantly, the commands have an initial comma. In v2 that's not valid. The same goes for all the directives, commands, and control flow statements.

Here's a .patch fixing the last issue and a couple of spelling issues. Perhaps there are more issues, I didn't check the file word by word, I just glanced over it.

ahk.json.patch.gz


EDIT: Uploaded the wrong archive, fixed now.

@mark-wiemer mark-wiemer added bug something isn't working template template for a new AHK script labels Dec 3, 2022
mark-wiemer added a commit that referenced this issue Dec 3, 2022
@mark-wiemer
Copy link
Member

I've addressed the template issues in a PR that'll auto-merge in a few minutes. Would you mind creating a separate issue for the snippets? v2 support will be difficult and I'm still focusing on low-hanging fruit, but I'm happy to consider any changes you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working template template for a new AHK script
Projects
None yet
Development

No branches or pull requests

2 participants