Fix examples #3
Merged
Fix examples #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 10, 2024 20:08
Previously, the time_stamp for all update methods was called dt. This can be confusing since these timestamps are absolute timestamps instead of delta time.
Fix the examples to replicate the actual behavior of the timestamps of the fusion algorithm.
mark2b
reviewed
Mar 10, 2024
src/fusion_impl.rs
Outdated
| @@ -15,7 +15,7 @@ impl Fusion { | |||
| hard_iron_offset: FusionVector::zero(), | |||
| ahrs, | |||
| offset: FusionGyrOffset::new(sample_rate), | |||
| last_dt: 0f32, | |||
| last_time_stamp: 0f32, | |||
There was a problem hiding this comment.
Lets change time_stamp & last_time_stamp to single word, timestamp & last_timestamp accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as discussed in issue #2 here is a PR fixing the examples. I'll provide the additional methods with durations in a separate PR another day.
I'd me happy about feedback on the code.