This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
Don't force the package to 'main' if the '-o' option was used. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markbates Any chance you could take a look at this and (hopefully) merge it? |
markbates
suggested changes
Mar 4, 2020
markbates
suggested changes
Mar 4, 2020
It looks like the problem is that pkger gets the information for the current directory, *then* appends the path from the '-o' option, but that means that the package name will always be main if it's started from the main package, regardless of '-o'. Fixes markbates#56.
I don't think, having reviewed the repo, that there are any existing tests for the things in the cmd directory (and I note that when you made the change that resulted in this problem, you didn't add any regression tests). I'm not averse to adding something, but you'll have to be reasonably specific about what you want and where you want it. If I make decisions about your project layout for you, my guess is that you're likely to reject them, which will result in unnecessary back and forth and wasted time at my end, which neither of us really wants. |
|
Guess this is officially "fixed". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the problem is that pkger gets the information for the current
directory, then appends the path from the '-o' option, but that means that
the package name will always be main if it's started from the main package,
regardless of '-o'.
Fixes #56.