Handle codeblocks that are nested #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymzh
commented
Jan 11, 2020
jaymzh
changed the title
jaymzh
force-pushed
the
codeblocks_in_things
branch
2 times, most recently
from
3637d0b to
45ff2db
Compare
If a codeblock is nested inside of either a list or another code block, it will have preceeding spaces, even if it is fenced, so ignore those spaces. Updates the testing ruleset to always include MD046 so we can catch more issues like this in the future and updates tests accordingly. Also adds various tests for this. This should close markdownlint#217 markdownlint#221 markdownlint#233. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
force-pushed
the
codeblocks_in_things
branch
from
45ff2db to
936c642
Compare
NaomiReeves
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a codeblock is nested inside of either a list or another
code block, it will have preceeding spaces, even if it is fenced, so
ignore those spaces.
Updates the testing ruleset to always include MD046 so we can catch
more issues like this in the future and updates tests accordingly.
Also adds various tests for this.
Related Issues
Should close #217 #221 #233 I think.
Types of changes
Checklist:
master, if not - rebase it