Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified for DSM 7.2, 7.1.1, and default to local logger #63

Closed
wants to merge 22 commits into from

Conversation

telnetdoogie
Copy link

@telnetdoogie telnetdoogie commented May 5, 2024

This modification fixes the name of the package and the packages directory from Docker to ContainerManager for DSM 7.2

It also changes the default logger to the local file logging driver which is a more efficient driver than the JSON File logging driver and also does file rotations by default, avoiding the potential issue of running out of file space on your host due to much larger and non-rotated log files accumulating.

I have not run into issues with this so far; I am able to start and stop containers from the Container Manager UI, all of my containers were able to run fine on custom network or default bridge with no issues. The only issue is the absense of any logs in the Container Manager UI. docker log works just fine, as do log-exposure apps like dozzle.

From the Docker documentation:

Docker keeps the json-file logging driver (without log-rotation) as a default to remain backward compatibility with older versions of Docker, and for situations where Docker is used as runtime for Kubernetes.

For other situations, the local logging driver is recommended as it performs log-rotation by default, and uses a more efficient file format

@telnetdoogie
Copy link
Author

Not sure how to assign this to you @markdumay - this also supercedes #62
Should also solve #60

This additional section advises users to stop all containers with compose before upgrade or restores, in order to avoid the errors with persisted logging mechanisms still referring to the DB logging plugin from Synology.
remove dupes from compose enumeration
modified command to identify compose-managed and non compose-managed containers
include tested DSM version 7.2.1
@telnetdoogie telnetdoogie changed the title modified for DSM 7.2 and default to local logger modified for DSM 7.2, 7.1.1, and default to local logger Jun 12, 2024
@telnetdoogie
Copy link
Author

Codefactor issues resolved; not sure how to trigger a re-run

@telnetdoogie telnetdoogie marked this pull request as draft September 10, 2024 09:30
@telnetdoogie telnetdoogie marked this pull request as ready for review September 10, 2024 09:30
@kapsh
Copy link

kapsh commented Oct 5, 2024

This is a must for Portainer, some of it's features wouldn't work with ancient Docker 20. Thank you, I've updated docker from your fork without any issues.

@telnetdoogie
Copy link
Author

telnetdoogie commented Oct 8, 2024

Given that this pull request hasn’t been reviewed in 5 months, and there hasn’t been activity in the project in several years either to master or develop, I am going to close this PR and maintain my own version of the fork.

@markdumay This is a really awesome foundation you've created. I have and will continue to make sure to credit your original repository in my version. ❤️

I’ll continue to update my version to work with modern DSM versions as much as I'm able to.

@telnetdoogie telnetdoogie deleted the local_logger branch October 8, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants