You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Fair question, not sure. I have not seen any PRs where tests were removed and all tests do pass; therefore, it works as specified. Having said that, it looks like there could be relatively drastic changes in the compiler or codebase??
See where "Please report this to" winds up in the previous (bottom) and current (top).
Also, looks like there's, what I call an uglifier (shortens var names), being applied that wasn't??
"this.renderer.list(body,ordered)" - left versus - this.renderer.list(l,o) - right.
If we trust the tests to cover Marked as known, I think we're okay.
2a92083
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why's the minified source much shorter than before?
2a92083
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair question, not sure. I have not seen any PRs where tests were removed and all tests do pass; therefore, it works as specified. Having said that, it looks like there could be relatively drastic changes in the compiler or codebase??
See where "Please report this to" winds up in the previous (bottom) and current (top).
Also, looks like there's, what I call an uglifier (shortens var names), being applied that wasn't??
"this.renderer.list(body,ordered)" - left versus - this.renderer.list(l,o) - right.
If we trust the tests to cover Marked as known, I think we're okay.