Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove failing test for now #1098

Merged
merged 2 commits into from
Feb 28, 2018
Merged

remove failing test for now #1098

merged 2 commits into from
Feb 28, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Feb 28, 2018

Marked version: 2ef9bbf

Description

Makes travis tests pass so we can see if PRs are actually failing

I just added .bak to the failing test so we can easily add it back once it is passing.

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • cm_autolinks is the only failing test (remove once CI is in place and all tests pass).
  • All lint checks pass (remove once CI is in place).
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech requested review from styfle and joshbruce February 28, 2018 16:01
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. We can't have the CI crying wolf all the time or else no one will look at it. Approved 👍

@joshbruce
Copy link
Member

Nice! Can you remove the two committer checkboxes as well?? I mean, two birds, one stone. 😊

@joshbruce
Copy link
Member

We should probably also create an issue...wait, I think I already did that... #1092

Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants