-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove failing test for now #1098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. We can't have the CI crying wolf all the time or else no one will look at it. Approved 👍
Nice! Can you remove the two committer checkboxes as well?? I mean, two birds, one stone. 😊 |
We should probably also create an issue...wait, I think I already did that... #1092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
remove failing test for now
Marked version: 2ef9bbf
Description
Makes travis tests pass so we can see if PRs are actually failing
I just added
.bak
to the failing test so we can easily add it back once it is passing.Contributor
Committer
In most cases, this should be a different person than the contributor.