Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link references in nested lists aren't parsed #1566

Closed
nex3 opened this issue Nov 27, 2019 · 2 comments · Fixed by #2112
Closed

Link references in nested lists aren't parsed #1566

nex3 opened this issue Nov 27, 2019 · 2 comments · Fixed by #2112
Labels
category: links category: lists L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue

Comments

@nex3
Copy link

nex3 commented Nov 27, 2019

Describe the bug

If a link reference appears in a nested list, it is not parsed correctly and its corresponding link won't render.

To Reproduce
Steps to reproduce the behavior:

  1. Marked Demo
  2. CommonMark Demo
@nex3
Copy link
Author

nex3 commented Nov 27, 2019

The same is true for link references in blockquotes in lists:

  1. Marked Demo
  2. CommonMark Demo

nex3 added a commit to sass/sass that referenced this issue Nov 27, 2019
@nex3
Fix broken link references
9f0cb1f 
This also moves a bunch of references around to work around
markedjs/marked#1566.
@UziTech UziTech added category: lists L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue category: links labels Nov 27, 2019
@calculuschild
Copy link
Contributor

This should be fixed by #2112

@styfle styfle linked a pull request Jun 24, 2021 that will close this issue
fix: Full Commonmark compliance for Lists #2112
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: links category: lists L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Full Commonmark compliance for Lists calculuschild/marked
3 participants
@nex3 @UziTech @calculuschild