Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gfm Tables Incorrectly Require Newlines Before Table #1733

Closed
chlafreniere opened this issue Jul 18, 2020 · 4 comments · Fixed by #2298
Closed

Gfm Tables Incorrectly Require Newlines Before Table #1733

chlafreniere opened this issue Jul 18, 2020 · 4 comments · Fixed by #2298
Labels
category: tables has PR The issue has a Pull Request associated L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue released

Comments

@chlafreniere
Copy link

gfm tables using marked require a line with just whitespace before the table definition:

test
|a|b|
|-|-|

renders just fine in GitHub:

test

a b

However, marked doesn't like it and doesn't render a table:
Marked Demo

test

|a|b|
|-|-|

works just fine both in marked and in GitHub:

test

a b

(above renders table as expected)

Expected behavior
marked's lexer is able to identify tables, even when the preceding line contains anything other than whitespace.

@UziTech UziTech added category: tables L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue labels Jul 18, 2020
@mainytht
Copy link

mainytht commented Aug 29, 2020

me too , not resolved . what now ?
there were a "tables: ture" options ever.
but now it disappeared in the new manual ,why?

@UziTech
Copy link
Member

UziTech commented Aug 29, 2020

You can add a blank line before the table to make it work.

@EmmetZC
Copy link
Contributor

EmmetZC commented Nov 22, 2021

Hi, guys.

Are you gonna fix this or do you think this is correct behavior?

@UziTech UziTech added the has PR The issue has a Pull Request associated label Nov 24, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tables has PR The issue has a Pull Request associated L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants