revert number of capturing parens in #1013 #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
+1, thanks This looks more commonmark compliant too (they don't require that leading and trailing spaces match) |
lib/marked.js
Outdated
| @@ -468,7 +468,7 @@ var inline = { | |||
| nolink: /^!?\[((?:\[[^\]]*\]|\\[\[\]]|[^\[\]])*)\]/, | |||
| strong: /^__([\s\S]+?)__(?!_)|^\*\*([\s\S]+?)\*\*(?!\*)/, | |||
| em: /^_([^\s_](?:[^_]|__)+?[^\s_])_\b|^\*((?:\*\*|[^*])+?)\*(?!\*)/, | |||
| code: /^(`+)(\s*)([\s\S]*?[^`]?)\2\1(?!`)/, | |||
| code: /^(`+)(?:\s*)([\s\S]*?[^`]?)(?:\s*)\1(?!`)/, | |||
There was a problem hiding this comment.
There's no need to capture then!
/^(`+)\s*([\s\S]*?[^`]?)\s*\1(?!`)/
|
This is a merge + publish (0.3.15), yeah? If so, makes me think we should have another owner who can publish...I’m at dinner, but if one of y’all could publish, we could increase our flow rate for hot-fix type things. Thoughts?? |
|
yeah, merge + publish I would be ok with more permission. |
|
@UziTech @Feder1co5oave - Any tests we can write to guard against future regression?? (Really looking forward to the CI thing.) Publishing |
|
Is anyone working on setting up CI? Maybe that's something I can help with. |
|
It's been set up in #1020, head over there and give us some advice if you
wish!
|
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
revert number of capturing parens in markedjs#1013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the number of capturing parentheses in
inline.codegrammar from #1013The regex should still function the same.
fixes #1059