-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3.17 (template updates) - ?? #1076
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
484698d
Initial commit
912ebfb
Separate default PR and release PR
9f8b337
Modify test passing criteria
ac73e28
Add marked version to default PR and ISSUE template
effe933
NPM publish and prepare next release come last
245fe2c
Add minify commit
a14ac2e
Merge branch 'master' into update-templates
f9c036d
minify
d36aea0
0.3.16
5f86cbe
0.3.17
c195d7f
Draft GitHub releases part of checklists
3cd7462
Include failable test
81f4511
Reviewer merges non-release PRs
6d0460f
Proposal template & what if
c621148
Make tests checkbox more concise
a8b50df
Added new features documentation submission
eeb1c7c
Add call stack and console log
321c50f
Update language of checklists to match AUTHORS
d0dc71e
Use correct failing test - pretty sure it used to be case_insensitive…
1f1ffbe
A little more detail around CI things
cc380a3
Merge branch 'master' into update-templates
5dc9e0e
Add snyk.io rep
55c6581
Add git commands for updating master from upstream
d69f14f
Update min
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,49 @@ | ||
|
||
<!-- | ||
|
||
If release PR, add ?template=release.md to the PR url to use the release PR template. | ||
|
||
Otherwise, you are stating the this PR fixes an issue that has been submitted; or, | ||
describes the issue or proposal under considersation. | ||
|
||
--> | ||
|
||
**Marked version:** | ||
|
||
<!-- The NPM version or commit hash having the issue --> | ||
|
||
## Description | ||
|
||
<!-- describe what the PR does --> | ||
- Fixes #### (if fixing a known issue; otherwise, describe issue using the following format) | ||
|
||
<!-- | ||
|
||
## Expectation | ||
|
||
Describe the output you are expecting from marked | ||
|
||
## Result | ||
|
||
Describe the output you received from marked | ||
|
||
## What was attempted | ||
|
||
- Fixes #### | ||
- Fixes list issues fixed by this PR | ||
- Fixes will automatically close them once merged | ||
Describe what code combination got you there | ||
|
||
## Review | ||
--> | ||
|
||
### Submitter | ||
## Contributor | ||
|
||
- [ ] All tests pass (CI should take care of this, once in place). | ||
- [ ] All lint checks pass (CI should take care of this, once in place). | ||
- Tests | ||
- [ ] Test(s) exist to ensure functionality works (if no new tests added, list which tests cover this functionality). | ||
- [ ] No tests required for this PR. | ||
- [ ] Is release: | ||
- [ ] Version in `package.json` has been updated (see [RELEASE.md](https://github.com/markedjs/marked/blob/master/RELEASE.md)). | ||
- [ ] The `marked.min.js` has been updated; or, | ||
- [ ] release does not change library. | ||
- [ ] Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or, | ||
- [ ] no tests required for this PR. | ||
- [ ] If submitting new feature, it has been documented in the appropriate places. | ||
|
||
## Committer | ||
|
||
### Reviewer | ||
In most cases, this should be a different person than the contributor. | ||
|
||
?? | ||
- [ ] Draft GitHub release notes have been updated. | ||
- [ ] cm_autolinks is the only failing test (remove once CI is in place and all tests pass). | ||
- [ ] All lint checks pass (remove once CI is in place). | ||
- [ ] CI is green (no forced merge required). | ||
- [ ] Merge PR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
## Publisher | ||
|
||
- [ ] `$ npm version` has been run. | ||
- [ ] Release notes in [draft GitHub release](https://github.com/markedjs/marked/releases) are up to date | ||
- [ ] Reviewer checklist is complete. | ||
- [ ] Merge PR. | ||
- [ ] Publish GitHub release using `master` with correct version number. | ||
- [ ] `$ npm publish` has been run. | ||
- [ ] Create draft GitHub release to prepare next release. | ||
|
||
Note: If merges to `master` occur after submitting this PR and before running `$ npm pubish` you should be able to | ||
|
||
1. pull from `upstream/master` (`git pull upstream master`) into the branch holding this version, | ||
2. run `$ npm run build` to regenerate the `min` file, and | ||
3. commit and push the updated changes. | ||
|
||
## Committer | ||
|
||
In most cases, this should be someone different than the publisher. | ||
|
||
- [ ] Version in `package.json` has been updated (see [RELEASE.md](https://github.com/markedjs/marked/blob/master/RELEASE.md)). | ||
- [ ] The `marked.min.js` has been updated; or, | ||
- [ ] release does not change library. | ||
- [ ] cm_autolinks is the only failing test (remove once CI is in place and all tests pass). | ||
- [ ] All lint checks pass (remove once CI is in place). | ||
- [ ] CI is green (no forced merge required). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a recommendation from @UziTech. Basically instead of build then commit
min
...let NPM + Git do it for us. As far as the details of what Git is actually doing I would have to read the docs.