Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched out tabs for spaces #1087

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Switched out tabs for spaces #1087

merged 2 commits into from
Feb 27, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Feb 26, 2018

Marked version: n/a

Description

#1085 introduced tabs not spaces to index.js.

#1086 introduced testing the lint in Travis, not fixing it.

Therefore, Travis fails.

Recommend merging this and #1082 to minimize future occurrences.

Submitter

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Reviewer

  • Draft GitHub release notes have been updated.
  • case_insensitive_refs is only failing test (remove once CI is in place and all tests pass).
  • All lint checks pass (remove once CI is in place).
  • Merge PR

@joshbruce joshbruce added the L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue label Feb 26, 2018
@joshbruce joshbruce requested a review from UziTech February 26, 2018 22:57
@UziTech
Copy link
Member

UziTech commented Feb 26, 2018

we also need to get the tests passing so we can start trusting travis. Is there someone working on that? or should we just remove that test for now?

@joshbruce
Copy link
Member Author

@UziTech: Agreed. Think @Feder1co5oave was trying to work that but, if we can solve that one test while he's doing his broader sweep of things, I'd be down. I don't regex for nothing and am still figuring Marked out a bit.

@joshbruce
Copy link
Member Author

joshbruce commented Feb 26, 2018

That's why the updated checklists being proposed in #1076 have those two Travis-related checkboxes. Fix that test and we can remove them...makes reviews a lot easier...would be nice to start building a coding standards part of the reviewer portion - but, one thing at a time.

@UziTech
Copy link
Member

UziTech commented Feb 27, 2018

I cleaned it up and changed it to display fractions of milliseconds.

This should be ready to merge.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants