Add self from OUJS Organization to AUTHORS.md #1233
Conversation
Technically this makes me a Contributor according to GH ;) LOL j/k I do what I can when I can. :)
<!--
If release PR, add ?template=release.md to the PR url to use the release PR template.
If badging PR, add ?template=badges.md to the PR url to use the badges PR template.
Otherwise, you are stating this PR fixes an issue that has been submitted; or,
describes the issue or proposal under consideration and contains the project-related code to implement.
-->
**Marked version:**
0.3.19
<!-- The NPM version or commit hash having the issue -->
**Markdown flavor:** Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
GitHub Flavored Markdown *(Perhaps CommonMark down the line)*
## Description
- Fixes the request at #1232 (comment) <!-- (if fixing a known issue; otherwise, describe issue using the following format) -->
<!--
If no issue exists that you're aware of. The maintainers should be able to figure out if it's a duplicate.
-->
## Expectation
<!--
Describe the output you are expecting from marked
-->
GitHub Flavoured Markdown of course.
## Result
<!--
Describe the output you received from marked
-->
Continued, awesome, markdown for > ~9437 users ... denoted.
## What was attempted
<!--
Describe what code combination got you there
-->
A subtle, indirect, request for Usership addition in a comment. :) Hopefully I got the badge of honour correct.
## Contributor
- [ ] Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
- [ ] no tests required for this PR.
- [ ] If submitting new feature, it has been documented in the appropriate places.
## Committer
In most cases, this should be a different person than the contributor.
- [ ] Draft GitHub release notes have been updated.
- [ ] CI is green (no forced merge required).
- [ ] Merge PR
* Per https://github.com/markedjs/marked/blob/8d738ee761c49e5623d1ae4dccf31e5674bcfff4/docs/AUTHORS.md#badges NOTES: * Sorry... less gratitude this way I think but will comply. :)
* Usually this is set to these values but I turned it off for this PR in case it blew up GH md. Had this happen once on another project. So crosses-fingers and things Ref: * https://github.com/markedjs/marked/blob/92f0ae232f48440cc1fbdcf91b7e3d87226ae05d/.editorconfig
|
Think it's ready for review. Cheers. |
* Wikipedia has their own redirects for browser language used for this link * Also lets portables redirect to mobile page if available.
* Don't know what I was thinking. :) okay enough O.C. for now.
|
Some interesting features this project utilizes on GH... sorry for the noise. Still getting used to these features. May adopt WIP at some point for our site as that's important. |
docs/AUTHORS.md
Outdated
| |Name |GiHub handle |Decision making |Badges of honor (tag for questions) | | ||
| |:--------------|:--------------|:----------------------------------------------------|------------------------------------| | ||
| |Marti Martz |@Martii |OpenUserJS.org Co-Owner / Project Active Maintainer |Open source, of course | | ||
|
|
There was a problem hiding this comment.
@Martii thanks, we hadn't figured out what to do on these tables. I was thinking it would be different than the others.
Maybe:
| Individual or organization | Website | Submitted by |
|---|---|---|
| OpenUserJS.org | https://openuserjs.org | Marti Martz (@Martii) Co-Owner / Project Active Maintainer |
If you would like to take the game dynamics (badges) to the OpenUserJS project right on!
There was a problem hiding this comment.
That looks really good... plus it seems narrower for those not using the Wide GitHub Usercript by xthexder (I try to take these things into account). May put in the @ symbol to our organization home @OpenUserJS since the linkage is in the website.... the .org is the project.
Will change momentarily.
There was a problem hiding this comment.
Oooooh! That @ thing...maybe a different column?? GitHub project - a lot of our users are other open source projects.
There was a problem hiding this comment.
maybe a different column??
Depends on how wide you want it. I use the aforementioned Userscript constantly but not everyone does so pushing the boundaries with more columns will make more word wraps. The reason I put spaces in between the / but didn't seem to do much. GFM can be picky sometimes.
We can try it if you like.
There was a problem hiding this comment.
I'm not too concerned about the width and word wraps from a PO perspective but it's a valid point. I also like the idea of linking directly to the project. Maybe something like this (adding another use to demonstrate the added value to other users:
| Individual or organization | Website | GitHub Project | Submitted by |
|---|---|---|---|
| OpenUserJS.org | https://openuserjs.org | Marti Martz (@Martii) Co-Owner / Project Active Maintainer | |
| Node Package Manager | https://www.npmjs.com | https://github.com/npm/npm | -- |
See how some users may not have the direct one-to-one you have??
There was a problem hiding this comment.
Note: The word wraps will potentially look and feel different here in the code review than on display on our site or by GH later.
There was a problem hiding this comment.
Ughh GH isn't updating your comments real time... totally missed these... will read after phone call...
* No badge column now so remove linkage reference * Not everyone's project name matches their DN so that's why I put the `@` symbol in for the Organization *(username on GH)*
|
@Martii: You know what, I think I'm asking you do something that might be easier if I just edited this directly. Would you mind me doing that? |
* This is the nomenclature and the compromise that can remove the `@` symbol by linking... similar to mentioning GH teams * Using relative URLS unless you plan on putting this on a custom domain * Since no-one elses `@`nick mention is hyperlinked not doing mine for symmetry * Not everyones project is hosted on GH btw... so `Project` is neutral... typically we use the word `Development`
|
@joshbruce What about now? |
* GFM is doing interesting things with md
|
@Martii: I do apologize, I was not becoming impatient, I just honestly didn't want you to feel like you should have to create something, that in all honesty, I (or one of the other core team) probably should have given a template for. :) LGTM! |
|
@Martii: One the other settings we have is that it takes two approvers before getting merged. So, someone else should be along. If they approve, they can merge and do all the other things. Thanks for being our first "registered" user! Very exciting stuff. Also, I'm curious about your (apparent) fascination with legal things. |
|
I am quite flexible when it comes to changes but I am also old school and have a telephone to attend too sometimes. ;) I also enjoy open source development... which is why I'm here. None of us gets paid (well usually not) so I prefer to be as polite as I can be.
Because I'm a non-attorney (which may change someday) advocate. I prefer to keep things neat and organized as possible... although sometimes that takes longer than usual in my day to day activities. Btw I am a small contributor directly to node as they are my favourite Company/Corp. :) |
|
Not sure how picky column alignment is in the source... Usually I would just not match the headers and separators to the item table columns/rows... so they are currently misaligned compared to rest but seems trivial I think (hope) |
Add self from OUJS Organization to AUTHORS.md
* Unfortunately @joshbruce lost some credibility by a post edit with an edit misusing the OpenUserJS brand so respectfully removing listing. NOTE: * This is probably why no-one else has done this Ref: * markedjs#1233 with > LGTM! ... apparently it wasn't and shouldn't have been merged without all parties consent.
Technically this makes me a Contributor according to GH ;) LOL j/k I do what I can when I can. :)
Marked version:
0.3.19
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
GitHub Flavored Markdown (Perhaps CommonMark down the line)
Description
Expectation
GitHub Flavoured Markdown of course.
Result
Continued, awesome, markdown for > ~9437 users ... denoted.
What was attempted
A subtle, indirect, request for Usership addition in a comment. :) Hopefully I got the badge of honour correct.
Contributor
Committer
In most cases, this should be a different person than the contributor.