Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escapedpipes #1239

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Escapedpipes #1239

merged 2 commits into from
Apr 25, 2018

Conversation

tomtheisen
Copy link

@tomtheisen tomtheisen commented Apr 25, 2018 •
edited by joshbruce
Loading

Marked version: 0.3.19

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

This PR adds support for escaped pipes inside GFM tables. \| can be used to embed a literal pipe inside a table cell.

This means compliance with GFM spec example #193.

Contributor

  • Test(s) exist to ensure functionality and minimize regression: Example 193 in gfm.0.28.json
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@tomtheisen tomtheisen mentioned this pull request Apr 25, 2018
Closed
UziTech
UziTech approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UziTech UziTech requested a review from joshbruce April 25, 2018 05:27
joshbruce
joshbruce approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. LGTM

@joshbruce joshbruce merged commit c5cc037 into markedjs:master Apr 25, 2018
@joshbruce joshbruce mentioned this pull request Apr 25, 2018
Merged
6 tasks
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 24, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 7, 2020
Open
Open
Open
Open
Open
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@joshbruce
Merge pull request markedjs#1239 from tomtheisen/escapedpipes
fcff5d5 
Escapedpipes
@snyk-bot snyk-bot mentioned this pull request Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

@joshbruce joshbruce joshbruce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GFM doesn't handle escaped pipes in code blocks
3 participants
@tomtheisen @UziTech @joshbruce