fix paragraph type #1248
Merged
fix paragraph type #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davisjam not sure if this makes the |
styfle
approved these changes
May 2, 2018
joshbruce
reviewed
May 2, 2018
test/specs/original/specs-spec.js
Outdated
|
|
||
| const tokens = marked.lexer(md); | ||
|
|
||
| expect(tokens[0].type).toBe('paragraph'); |
There was a problem hiding this comment.
Think this makes more sense to be in the unit tests, yeah? The construction seems similar enough and this isn't, technically speaking, checking a specific spec or the output as a whole.
|
@UziTech Looks OK. |
UziTech
commented
May 2, 2018
| marked.parse('Hello World!'); | ||
| expect(marked.parse).toHaveBeenCalled(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I removed this test as well since it didn't really do anything. and was just there initially to have a test
joshbruce
approved these changes
May 2, 2018
|
@UziTech - looks like - is this a false positive in security check? The regexes don't seem to match what was changed. |
|
travis is just hung up on the security scan. this PR is good to go |
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Mar 25, 2020
This was referenced Apr 1, 2020
This was referenced Apr 8, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
fix paragraph type
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 37c0324
Description
paragraphbecomestextin master #1247Contributor
Committer
In most cases, this should be a different person than the contributor.