-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommonMark code block class names #1265
Conversation
I'll look into the failing tests later, Travis appears to be down at the moment (rendering only a blank white page). |
looks like the tests and example 111 and 113 can be taken out of
|
@UziTech Updating right now. Pushing a new commit within 5 mins. Sorry I missed them earlier. |
Ok, new commit pushed. Tests pass for me locally. Thank you so much for the help and super fast response, @UziTech! |
No problem. Thanks for the PR 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert marked.min.js
that will be updated automatically when the PR is merged
man/marked.1.txt
Outdated
@@ -56,7 +56,7 @@ OPTIONS | |||
--smart-lists | |||
Use smarter list behavior than the original markdown. | |||
|
|||
--lang-prefix [prefix] | |||
--language-prefix [prefix] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this parameter should still be --lang-prefix
since that is what the option is called
Fixing everything now, pushing in a few moments. Will undo the changes to marked.min.js in my other PR as well. |
man/marked.1.txt
Outdated
@@ -8,7 +8,7 @@ NAME | |||
|
|||
SYNOPSIS | |||
marked [-o <output>] [-i <input>] [--help] [--tokens] [--pedantic] | |||
[--gfm] [--breaks] [--tables] [--sanitize] [--smart-lists] [--lang-pre‐ | |||
[--gfm] [--breaks] [--tables] [--sanitize] [--smart-lists] [--language-pre‐ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also be --lang
Ok all changes in and fixed the Git history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉 Thanks again 🥇
This will be a breaking change but our next release has several breaking changes so good timing, thanks! 👍 |
CommonMark code block class names
This is a very simple fix to follow the CommonMark spec for code blocks:
https://spec.commonmark.org/0.27/ Example: https://spec.commonmark.org/0.27/#example-109
Right now Marked defaults to
lang-
for fenced code blocks, which as far I understand it, is legacy from Highlight.js. By enforcing the CommonMark standard developers will be able to leverage other CommonMark tools when using output from Marked.Contributor
Committer
In most cases, this should be a different person than the contributor.