enable CommonMark spec 468 #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minor adjustment to the href-matching regexp permits CommonMark spec 468 to pass. All other passing specs are unaffected. The regexp was incorrectly excluding parentheses as valid characters in a URL.
UziTech
approved these changes
Jul 3, 2018
joshbruce
approved these changes
Jul 5, 2018
|
Thanks! |
|
@styfle Just got a chance to look at this. I will cryptically remark that its vulnerability status is unchanged. |
Closed
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
This was referenced Mar 30, 2020
This was referenced Apr 6, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
enable CommonMark spec 468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 0.4.0
Markdown flavor: CommonMark
Description
A minor adjustment to the href-matching regexp permits CommonMark spec
468 to pass. All other passing specs are unaffected.
The regexp was incorrectly excluding parentheses as valid characters in
a URL.
Contributor
Committer
In most cases, this should be a different person than the contributor.