Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.2 #1441

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Release 0.6.2 #1441

merged 1 commit into from
Apr 5, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Mar 8, 2019

Publisher

  • $ npm version has been run.
  • Release notes in draft GitHub release are up to date
  • Release notes include which flavors and versions of Markdown are supported by this release
  • Committer checklist is complete.
  • Merge PR.
  • Publish GitHub release using master with correct version number.
  • $ npm publish has been run.
  • Create draft GitHub release to prepare next release.

Note: If merges to master occur after submitting this PR and before running $ npm pubish you should be able to

  1. pull from upstream/master (git pull upstream master) into the branch holding this version,
  2. run $ npm run build to regenerate the min file, and
  3. commit and push the updated changes.

Committer

In most cases, this should be someone different than the publisher.

  • Version in package.json has been updated (see PUBLISHING.md).
  • The marked.min.js has been updated; or,
  • release does not change library.
  • CI is green (no forced merge required).

@styfle styfle requested review from UziTech, joshbruce and davisjam March 8, 2019 23:04
@UziTech
Copy link
Member

UziTech commented Mar 9, 2019

I would like to get #1438 and #1439 merged before this release

@styfle
Copy link
Member Author

styfle commented Mar 9, 2019

@UziTech Would you consider both #1438 and #1439 semver patches?

The changes we've merged so far were fixes for regressions so I feel like we can ship a patch asap for the Node Docs team.

/cc @joshbruce

@UziTech
Copy link
Member

UziTech commented Mar 9, 2019

Ya they are definitely patches. They both fix rare conditions that would be considered broken if anyone stumbled upon them.

@UziTech UziTech mentioned this pull request Mar 13, 2019
4 tasks
@styfle
Copy link
Member Author

styfle commented Mar 25, 2019

@UziTech Is this still considered a patch release?

Security

Fixes

Enhancements

CLI

Testing

@UziTech
Copy link
Member

UziTech commented Mar 25, 2019

I think it still is a patch release. I don't see anything that will break current workflows.

@UziTech
Copy link
Member

UziTech commented Apr 5, 2019

@davisjam @joshbruce can we get another approval so we can release a new version?

@styfle styfle merged commit 529a8d4 into markedjs:master Apr 5, 2019
@styfle styfle deleted the release-0.6.2 branch April 5, 2019 14:27
@styfle
Copy link
Member Author

styfle commented Apr 5, 2019

zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants