Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break nptables on block-level structures #1617

Merged
merged 4 commits into from
Mar 17, 2020
Merged

break nptables on block-level structures #1617

merged 4 commits into from
Mar 17, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 9, 2020

Marked version: master

Markdown flavor: GitHub Flavored Markdown

Description

This PR copies #1598 to add breaking block-level rules to nptable (tables that don't start or end with a pipe)

e.g:

# nptable

 abc | def
 --- | ---
  1  |  2
  3  |  4

# table

| abc | def |
| --- | --- |
|  1  |  2  |
|  3  |  4  |

I also removed allowing setext header from breaking a table since it doesn't break on github. We can change it later easily if github changes. see #1598 (review)

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR).

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Mar 9, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/6rqwcwe36
✅ Preview: https://markedjs-git-fork-uzitech-following-nptable.markedjs.now.sh

src/rules.js Outdated Show resolved Hide resolved
src/rules.js Outdated Show resolved Hide resolved
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UziTech UziTech requested review from davisjam and joshbruce March 9, 2020 22:25
@UziTech
Copy link
Member Author

UziTech commented Mar 17, 2020

@joshbruce could you review this so we can release v0.8.1

@UziTech UziTech mentioned this pull request Mar 17, 2020
12 tasks
@joshbruce
Copy link
Member

So glad to see all the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants