Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev deps #1730

Merged
merged 2 commits into from
Jul 13, 2020
Merged

update dev deps #1730

merged 2 commits into from
Jul 13, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Jul 13, 2020

Description

Update all devDependencies

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Jul 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/42l18wmak
✅ Preview: https://markedjs-git-fork-uzitech-update-deps.markedjs.vercel.app

@UziTech UziTech requested review from styfle, davisjam and joshbruce July 13, 2020 13:51
@UziTech UziTech added the dependencies Pull requests that update a dependency file label Jul 13, 2020
"@markedjs/html-differ": "^3.0.2",
"cheerio": "^1.0.0-rc.3",
"commonmark": "0.29.x",
"eslint": "^7.0.0",
"commonmark": "0.29.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to change commonmark? I noticed that markdown and markdown-it still use the x syntax.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya since we are using 0.29.1 specs I figured we should probably pin it and update this dependency when we update the specs.

@UziTech UziTech merged commit 7fbee6e into markedjs:master Jul 13, 2020
@UziTech UziTech deleted the update-deps branch July 13, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants