Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove quotes at the end of gfm autolink #2673

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: remove quotes at the end of gfm autolink #2673

merged 1 commit into from
Dec 7, 2022

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Dec 4, 2022

Marked version: 4.2.3

Markdown flavor: GitHub Flavored Markdown

Description

GFM spec states that trailing puncutation (?, !, ., ,, :, *, _, and ~) are removed from the url but in the implementation ' and " are also removed. This technically breaks the GMF spec but follows the implementation closer.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Dec 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marked-website ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 4:03AM (UTC)

@UziTech UziTech merged commit 697ac2a into markedjs:master Dec 7, 2022
@UziTech UziTech deleted the autolink-quotes branch December 7, 2022 07:44
github-actions bot pushed a commit that referenced this pull request Dec 7, 2022
@semantic-release-bot
chore(release): 4.2.4 [skip ci]
f2f9969 
## [4.2.4](v4.2.3...v4.2.4) (2022-12-07)

### Bug Fixes

* loose list items are loose ([#2672](#2672)) ([df4eb0e](df4eb0e))
* remove quotes at the end of gfm autolink ([#2673](#2673)) ([697ac2a](697ac2a))
* use paragraph token in blockquote in list ([#2671](#2671)) ([edc857c](edc857c))
This was referenced May 19, 2024
Open
Open
Open
Open
@ragnarstolsmark ragnarstolsmark mentioned this pull request May 24, 2024
Closed
@cezaraugusto cezaraugusto mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
This was referenced May 25, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 1, 2024
Open
Open
Open
Open
@Nagraj-Shankar Nagraj-Shankar mentioned this pull request Sep 20, 2024
Open
@teachmesomethingnewtoday teachmesomethingnewtoday mentioned this pull request Sep 20, 2024
Open
@rm-neilsondesa rm-neilsondesa mentioned this pull request Sep 20, 2024
Open
@SebAllouche SebAllouche mentioned this pull request Sep 21, 2024
Open
@Nagraj-Shankar Nagraj-Shankar mentioned this pull request Sep 21, 2024
Open
@rm-neilsondesa rm-neilsondesa mentioned this pull request Sep 22, 2024
Open
@Nagraj-Shankar Nagraj-Shankar mentioned this pull request Sep 23, 2024
Open
@rm-neilsondesa rm-neilsondesa mentioned this pull request Sep 23, 2024
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Sep 23, 2024
Open
@SebAllouche SebAllouche mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@mani-elumalai mani-elumalai mentioned this pull request Sep 29, 2024
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Oct 1, 2024
Open
@rdegges rdegges mentioned this pull request Oct 3, 2024
Open
@stefan-ionita3113 stefan-ionita3113 mentioned this pull request Oct 3, 2024
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Oct 3, 2024
Open
@thomas-ouellette thomas-ouellette mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Oct 24, 2024
Open
This was referenced Oct 26, 2024
Open
Open
This was referenced Oct 27, 2024
Open
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Nov 1, 2024
Open
@Sangram99-hacker Sangram99-hacker mentioned this pull request Nov 2, 2024
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Nov 2, 2024
Open
@joh748 joh748 mentioned this pull request Nov 4, 2024
Open
@mkajitansnyk mkajitansnyk mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

@davisjam davisjam Awaiting requested review from davisjam

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URLs wrapped in quotes include closing quote
2 participants
@UziTech @styfle