fix: Add support for Node 16

[benmccann]

Marked version: master

Markdown flavor: n/a

Description

• Fixes fix: update min node to v18 #2767 (comment)

Node 16 is still supported until September and there's no code in marked that doesn't work on Node 16, so it's unnecessarily aggressive to disallow it.

Expectation

Should be able to run marked on Node 16

Result

engines field gets in the way prior to this PR

Contributor

• Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
• no tests required for this PR.
• If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

• CI is green (no forced merge required).
• Squash and Merge PR following conventional commit guidelines.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
marked-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 22, 2023 8:18pm

[styfle]

I’m surprised tests are passing. We probably need to bump the target output to truly drop node 16 come September https://nodejs.org/gl/blog/announcements/nodejs16-eol

[UziTech]

Our docs state that we support lts and current node. The engines field should reflect what versions we support not what versions happen to work.

[benmccann]

Well Node 16 is an LTS release: https://nodejs.dev/en/about/releases/. And in any case, we could easily change the language on https://github.com/markedjs/marked#compatibility to cover Node 16. It's pretty frustrating that this package works on Node 16 without issue and I'm being banned from running it there anyway. I don't quite understand the reasoning behind that or what the benefit is. And it seems like a lot of other people are frustrated too: #2767 (comment)

[UziTech]

The reasoning is that none of us on the markedjs team want to debug issues on older versions of node. We have limited free time and would like to focus that time on versions of node we use. If you would like to join the team and help maintain older versions you are welcome to. We do appreciate the work you have done on marked 😁👍.

You can still use it. There are many well documented ways to get around the engines version. You can use --ignore-engines or create your own npm package that just depends on marked and uses babel to ensure a certain es output.

[benmccann]

Sure, if there are any issues that arise on the oldest version of Node, but not more recent versions, I don't mind being responsible for those

[styfle]

Sounds easy enough - once 16.x added to CI then the issues will present themselves if a PR causes 16.x to regress 👍

[yoyo837]

Can this PR solve the problem mentioned in #2767 (comment)? Semantic release requires node v18.

[yoyo837]

@UziTech Can you help check this please?

[benmccann]

thank you!!