Fix unicode Regex miscounting emoji length #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many emojis are 2+ unicode bytes long. The \u tag which allows searching for punctuation also counts emojis as single chars. Slicing the strings into an array restores the correct character count.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
Aug 14, 2023
UziTech
approved these changes
Aug 14, 2023
styfle
approved these changes
Aug 14, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
## [7.0.3](v7.0.2...v7.0.3) (2023-08-15) ### Bug Fixes * Fix unicode Regex miscounting emoji length ([#2942](#2942)) ([f3af23e](f3af23e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many emojis are 2+ unicode chars long. The \u tag which allows searching for punctuation also counts emojis as single chars, which throws off character count when slicing strings. Spreading the strings into an array restores the correct character count. There is probably some overhead slowdown but not that I can detect.
Eventually the
\vregex tag (in Node 20) can replace\uto get an accurate char count natively.Contributor
Committer
In most cases, this should be a different person than the contributor.