Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix space removed after checkbox #2971

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fix: fix space removed after checkbox #2971

merged 2 commits into from
Sep 6, 2023

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Sep 5, 2023

Marked version: 8.0.0

Description

Fixes #2970

Add back space after checkbox in task list.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Sep 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 1:42am

calculuschild
calculuschild approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@calculuschild calculuschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, although I'm curious what caused this behavior to change?

@UziTech
Copy link
Member Author

UziTech commented Sep 6, 2023

The space was removed in #2936 accidentally. The space was in the checkbox renderer for non-loose lists.

@calculuschild
Copy link
Contributor

Ok, I see it. 👍

Is the Parser where we want to be inserting spaces like this? Or was the Renderer more appropriate?

I.e., decoding the tokens vs deciding how to display them?

I don't have an opinion either way, just wondering why it was in the renderer to begin with.

@UziTech
Copy link
Member Author

UziTech commented Sep 6, 2023

Not sure why it was in the renderer to begin with but I feel like the checkbox renderer should just render the checkbox element.

@UziTech UziTech merged commit 9a2a4ad into markedjs:master Sep 6, 2023
10 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 6, 2023
@semantic-release-bot
chore(release): 8.0.1 [skip ci]
ccc7a8f 
## [8.0.1](v8.0.0...v8.0.1) (2023-09-06)

### Bug Fixes

* deprecated trimLeft/trimRight ([#2973](#2973)) ([eda75a6](eda75a6))
* fix space removed after checkbox ([#2971](#2971)) ([9a2a4ad](9a2a4ad))
@webstech webstech mentioned this pull request Sep 7, 2023
Closed
@UziTech UziTech deleted the checkbox-space branch September 16, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calculuschild calculuschild calculuschild approved these changes

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task list in v8.0.0 has no space after check box
3 participants
@UziTech @calculuschild @styfle