fix: run spec tests with testutils #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UziTech
changed the title
styfle
reviewed
Oct 5, 2023
styfle
reviewed
Oct 5, 2023
styfle
reviewed
Oct 5, 2023
| @@ -0,0 +1,49 @@ | |||
| import { Marked } from '../lib/marked.esm.js'; | |||
There was a problem hiding this comment.
So an extension package will just need to make their own version of this file to run spec tests, right?
I'm most interested in spec tests, but is there a similar capability for running unit tests?
There was a problem hiding this comment.
Ya, there is a getAllMarkedSpecTests() method to get the marked specs.
There was a problem hiding this comment.
I'm not using that method in marked because we want to be able to run tests that are created in PRs.
There was a problem hiding this comment.
Here is an example PR for an extension to run all marked tests
styfle
approved these changes
Oct 9, 2023
Co-authored-by: Steven <steven@ceriously.com>
UziTech
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2023
# [10.0.0](v9.1.6...v10.0.0) (2023-11-11) ### Bug Fixes * run spec tests with testutils ([#3017](#3017)) ([014d4e6](014d4e6)) ### BREAKING CHANGES * drop support for node v16
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use @markedjs/testutils to run tests with node test runner
BREAKING CHANGE: test runner doesn't work in node v16
Contributor
Committer
In most cases, this should be a different person than the contributor.