Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#269 #968

Closed
wants to merge 1 commit into from
Closed

#269 #968

wants to merge 1 commit into from

Conversation

jguffey
Copy link

@jguffey jguffey commented Dec 5, 2017

WRT escaping quotes that appear in HTML

Implements solution suggested in #269, also breaks tests.

WRT escaping quotes that appear in HTML
@joshbruce
Copy link
Member

@jguffey: Thanks for the PR!

Could you do me a favor and write unit tests demonstrating this in use? I'm not familiar with the library enough to understand what would be the optimum solution, the test will help me, and others, understand what's going on.

Thanks!

@joshbruce
Copy link
Member

Closing as merge conflicts, missing tests, and no response in the last 30 days.

@joshbruce joshbruce closed this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants