Fixes failing attribute defined test

[bencroker]

Running on Craft 5 results in the error, Calling unknown method: craft\fields\Dropdown::valueType().

The code in question is failing because the attribute is defined test on objects that extend the Component class (or any class that implements __call()) always returns true.

craft-pest-core/stubs/compiled_classes/FactoryFields.twig

Lines 7 to 10 in cd7edd6

	{% if attribute(field, 'valueType') is defined %}
	{% set type = field.valueType() %}
	{% elseif attribute(field, 'phpType') is defined %}
	{% set type = field.phpType() %}

This is a known issue.

This PR is a simple workaround that performs the check based on the Craft versions.

 {% for field in fields %}
 {% if craft.app.version < 5 %}
{% set type = field.valueType() %}
{% elseif craft.app.version > 5 and (attribute(field, 'phpType') is defined) %}

There’s probably a more elegant way to check for Craft version, I’ll leave that up to you.
Running on Craft 5, the “attribute is defined” test is failing and resulting in the error, Calling unknown method: craft\fields\Dropdown::valueType().

I also found that type needs a default value since it may not be set when tested against

craft-pest-core/stubs/compiled_classes/FactoryFields.twig

Line 18 in cd7edd6

{% if 'craft\\elements\\db\\MatrixBlockQuery' in type %}

Resulting in this working code.

 {% set type = 'mixed' %}
 {% for field in fields %}
 {% if craft.app.version < 5 %}
{% set type = field.valueType() %}
{% elseif craft.app.version > 5 %}
{% set type = field.phpType() %}
{% endif %}

[khalwat]

So I did a deep dive on this a while ago to figure out what was going on...

    {% if craft.mattwilcox is defined %}
        <p>Hi, Matt!</p>
    {% endif %}

compiles down to this PHP:

        // line 18
        if (craft\helpers\Template::attribute($this->env, $this->source, ($context["craft"] ?? null), "mattwilcox", [], "any", true, true)) {
            // line 19
            echo "        <p>Hi, Matt!</p>

which ends up calling getAttribute() in Twig's CoreExtension.php class, and because the craft variable object implements the PHP magic method __call https://www.php.net/manual/en/language.oop5.overloading.php#object.call it falls through to here: https://github.com/twigphp/Twig/blob/3.x/src/Extension/CoreExtension.php#L1698 and since $isDefinedTest = true it just returns that it's defined.

TL;DR: because the craft object implements the PHP __call magic method, it could dynamically return anything as being defined, so it just says it's defined. So literally anything will be "defined" as a property on an object that implements __call in Twig