Fix Deprecation Notice in RefreshTokenAuthenticator::start Method #389
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly marked parameter as nullable in the start method of the RefreshTokenAuthenticator class to comply with PHP 8.1+ standards.
mbabker
approved these changes
Dec 3, 2024
maxhelias
approved these changes
Dec 3, 2024
metalmumu
approved these changes
Jan 7, 2025
muriel-hublo
approved these changes
Jan 7, 2025
|
@gzim324 here is the same issue, please check it as well |
This was referenced Jan 11, 2025
- Update the type hint of the parameter in the start method from AuthenticationException to ?AuthenticationException. - Enhance code clarity and ensure consistency with nullable parameter type definition.
okorneliuk
reviewed
Jan 15, 2025
| @@ -178,7 +178,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio | |||
| return $this->failureHandler->onAuthenticationFailure($request, $exception); | |||
| } | |||
|
|
|||
| public function start(Request $request, AuthenticationException $authException = null): Response | |||
| public function start(Request $request, ?AuthenticationException $authException = null): Response | |||
SebLevDev
approved these changes
Jan 24, 2025
karpilin
approved these changes
Jan 31, 2025
|
Can somebody hit the merge button here? Thank you |
JanTvrdik
approved these changes
Feb 6, 2025
janedbal
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Deprecation Notice in RefreshTokenAuthenticator::start Method
Summary
This pull request addresses a deprecation notice in the
GesdinetJWTRefreshTokenBundlecaused by thestartmethod in theRefreshTokenAuthenticatorclass. The$authExceptionparameter was implicitly nullable, which is deprecated in PHP 8.1+.Changes Made
startmethod inRefreshTokenAuthenticatorto explicitly declare the$authExceptionparameter as nullable.Environment
Additional Context
This change ensures compatibility with PHP 8.1+ and eliminates the deprecation notice in development and test environments.